Skip to content

Fix mismatched_lifetime_syntaxes lint errors#311

Merged
KSXGitHub merged 2 commits into
KSXGitHub:masterfrom
johnDeSilencio:bugfix/mismatched-lifetimes-syntaxes-lint
Sep 2, 2025
Merged

Fix mismatched_lifetime_syntaxes lint errors#311
KSXGitHub merged 2 commits into
KSXGitHub:masterfrom
johnDeSilencio:bugfix/mismatched-lifetimes-syntaxes-lint

Conversation

@johnDeSilencio

Copy link
Copy Markdown
Contributor

Problem

On Rust 1.89, the mismatched_lifetime_syntaxes lint was added to the compiler. Because parallel-disk-usage disables all warnings, compiling pdu on Rust 1.89 results in a hard compiler error:

image

Solution

Following suggestions from rustc, it's trivial to add in the missing annotations:

image image

P.S. Super great tool you've made here! Thanks for all the hard work you do to maintain it. pdu is definitely the tool I reach for when my WSL at work gets a little too full :)

@KSXGitHub

Copy link
Copy Markdown
Owner

You may want to edit the rust-toolchain file.

@KSXGitHub

Copy link
Copy Markdown
Owner

It seems that installing with cargo install would cause these errors. Is there anyway to make the lint error only in git repo?

@johnDeSilencio

Copy link
Copy Markdown
Contributor Author

Done! Bumped the toolchain version to 1.89.0

@johnDeSilencio

johnDeSilencio commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

It seems that installing with cargo install would cause these errors. Is there anyway to make the lint error only in git repo?

Sorry, just to clarify, you want some way to deny the warning when running cargo build or cargo test but not when running cargo install?

@johnDeSilencio

Copy link
Copy Markdown
Contributor Author

Looks like there are also some performance regressions. Not really sure where those are coming from? The toolchain bump probably?

@KSXGitHub

Copy link
Copy Markdown
Owner

Sorry, just to clarify, you want some way to deny the warning when running cargo build or cargo test but not when running cargo install?

Yep.

@KSXGitHub KSXGitHub merged commit b41f259 into KSXGitHub:master Sep 2, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants